[Toybox] [PATCH] mktemp: fix the tests and the logic.

Rob Landley rob at landley.net
Thu Dec 6 10:48:16 PST 2018


On 12/6/18 10:55 AM, enh wrote:
> it occurred to me overnight that the passwd code allows '/'. plus, as
> i've said, it seems to be slightly wrong. so i've just sent a
> replacement for my second patch (to be applied on top of the first
> patch) that just does the simplest xgetrandom + convert to valid
> character loop.
> 
> can we at least get the first patch in, since mktemp is pretty broken
> right now (_except_ for -u, which was all the old tests exercised)?

Can you send me just a tests/mktemp.test patch to demonstrate the failures? I'll
try to fix it this evening. (Too many changes at once, I need to know what
success looks like...)

Thanks,

Rob



More information about the Toybox mailing list