[Toybox] [PATCH] mktemp: fix the tests and the logic.

[enh]

On Thu, Dec 6, 2018 at 10:48 AM Rob Landley <rob at landley.net> wrote:
>
> On 12/6/18 10:55 AM, enh wrote:
> > it occurred to me overnight that the passwd code allows '/'. plus, as
> > i've said, it seems to be slightly wrong. so i've just sent a
> > replacement for my second patch (to be applied on top of the first
> > patch) that just does the simplest xgetrandom + convert to valid
> > character loop.
> >
> > can we at least get the first patch in, since mktemp is pretty broken
> > right now (_except_ for -u, which was all the old tests exercised)?
>
> Can you send me just a tests/mktemp.test patch to demonstrate the failures? I'll
> try to fix it this evening. (Too many changes at once, I need to know what
> success looks like...)

you could just apply the two patches... that way you'll have the tests
_and_ they'll pass. (the _real_ question is whether we're still
missing important tests, since we were only testing -u until now. plus
testing "the Xs get replaced with random data" is inherently hard to
test.)

i've attached "just the tests" to this mail.

> Thanks,
>
> Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mktemp-just-the-missing-tests.patch
Type: text/x-patch
Size: 2159 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20181206/5cd98efc/attachment-0003.bin>