[Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

Rob Landley rob at landley.net
Wed Jan 24 08:18:34 PST 2018


On 01/23/2018 05:13 PM, enh wrote:
> This reverts commit 416397e14858c75a9bf20d05f7729595e03943df.
> 
> Reason: this breaks -AT while not actually fixing the -T PID problem.
> 
> Previously just the -T PID case was showing the same information (most
> obviously COMMAND) for each thread. With this patch, -AT now has the
> same bug.

Ok, obviously I don't understand the use case. What's the behavior
that's wrong, so I can fix it?

What that change did was make this match (2273 is the PID of the parent
chromium-browser process):

  $ ./ps -T 2273 | wc -l
  37
  $ ps -T 2273 | wc -l
  37

I.E. show the same number of lines out output when doing ps -T $PID on a
process with a lot of threads. Before that:

  $ git checkout 416397e14858c75^1
  $ ./ps -T 2273 | wc -l
  2

I.E. just header and the parent process, no threads.

You want it to go _back_ to this old behavior, the new one where it
matches the other ps is wrong?

I see that in "ps -A 2273", the -A overrides the specific PID. I hadn't
noticed that before. Is this the regression? You want -A to override
PIDs listed on the command line?

Confused,

Rob



More information about the Toybox mailing list