[Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

[enh]

On Wed, Jan 24, 2018 at 8:18 AM, Rob Landley <rob at landley.net> wrote:
> On 01/23/2018 05:13 PM, enh wrote:
>> This reverts commit 416397e14858c75a9bf20d05f7729595e03943df.
>>
>> Reason: this breaks -AT while not actually fixing the -T PID problem.
>>
>> Previously just the -T PID case was showing the same information (most
>> obviously COMMAND) for each thread. With this patch, -AT now has the
>> same bug.
>
> Ok, obviously I don't understand the use case. What's the behavior
> that's wrong, so I can fix it?

with this patch we get the right number of *lines* of output, but the
data is wrong. it seems like it's the same data repeated N times. like
i said, this is most obvious in the case of something like COMMAND ---
all threads get the same name.

> What that change did was make this match (2273 is the PID of the parent
> chromium-browser process):
>
>   $ ./ps -T 2273 | wc -l
>   37
>   $ ps -T 2273 | wc -l
>   37
>
> I.E. show the same number of lines out output when doing ps -T $PID on a
> process with a lot of threads. Before that:
>
>   $ git checkout 416397e14858c75^1
>   $ ./ps -T 2273 | wc -l
>   2
>
> I.E. just header and the parent process, no threads.
>
> You want it to go _back_ to this old behavior, the new one where it
> matches the other ps is wrong?

having -AT broken breaks bug reports, because ps -AT is part of every
bug report. i need to revert this today, because bug reports must
work.

having -T PID broken only hurts command-line users.

> I see that in "ps -A 2273", the -A overrides the specific PID. I hadn't
> noticed that before. Is this the regression? You want -A to override
> PIDs listed on the command line?

don't care. (ideally seems like that's an error, but procps seems to
agree that "-A wins", which i suppose makes a kind of sense given that
multiple -p filters are ORed together.)

> Confused,
>
> Rob
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net