[Toybox] [PATCH] xargs: "proper" fix for E2BIG.

enh enh at google.com
Thu Oct 24 15:19:46 PDT 2019


ping?

i've tested both this fix and the hacky (but findutils-like) fix on
macOS, and they fix the macOS build issues i'd been seeing.

i've also tried both fixes with the Android kernel build that was
failing, and both fix that too.

so the good news is we have two fixes. the bad news is we have two fixes :-)

if you're not happy with either, let me know what else you want to see...

On Tue, Oct 22, 2019 at 1:20 PM enh <enh at google.com> wrote:
>
> This change switches xargs over to correct accounting of space, and
> differentiating between the -s limit (which doesn't include the (char *)
> overhead) and the kernel limit (which does).
>
> I've added the two easy repro cases (at least for my desktop and
> laptop), but left them commented out since they're a bit questionable as
> tests.
> ---
>  tests/xargs.test   |  6 ++++++
>  toys/posix/xargs.c | 38 ++++++++++++++++++++++++--------------
>  2 files changed, 30 insertions(+), 14 deletions(-)



More information about the Toybox mailing list