[Toybox] [PATCH] xargs: "proper" fix for E2BIG.

Rob Landley rob at landley.net
Sun Oct 27 23:12:51 PDT 2019


On 10/24/19 5:19 PM, enh via Toybox wrote:
> ping?
> 
> i've tested both this fix and the hacky (but findutils-like) fix on
> macOS, and they fix the macOS build issues i'd been seeing.
> 
> i've also tried both fixes with the Android kernel build that was
> failing, and both fix that too.
> 
> so the good news is we have two fixes. the bad news is we have two fixes :-)
>
> if you're not happy with either, let me know what else you want to see...

I tried changing the -2048 to -4096 and I still got the kernel saying "Argument
too long" from my "find /usr -print0 | toybox xargs -0" test (but not on the
first echo call, on the second). that's why I haven't checked that in as a
temporary fix yet.

I need to dig more to understand what's going wrong here, but I've been trying
to dig out from my backlog in chronological order. :)

Rob



More information about the Toybox mailing list