[Toybox] [PATCH] chmod: support complex modes.

enh enh at google.com
Thu Dec 3 14:52:48 PST 2020


Change 5109da9b3e6a898c8e0ad647303a1b375e3d97d3 caused test.test to call
chmod with mode `u+s+s` which passes on the host (where you have a
toybox test but a GNU chmod) but fails on Android where chmod is toybox
too.

Add the missing loop to string_to_mode(), which means this will also
affect other toys, but that seems like a feature (and, for example, GNU
mkdir also accepts a mode like `a=r+w+x`).
---
 lib/lib.c        | 76 +++++++++++++++++++++++++-----------------------
 tests/chmod.test |  1 +
 2 files changed, 41 insertions(+), 36 deletions(-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20201203/77cebab9/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-chmod-support-complex-modes.patch
Type: text/x-patch
Size: 4213 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20201203/77cebab9/attachment-0002.bin>


More information about the Toybox mailing list