[Toybox] [PATCH] dirtree_path: always honor size request.

Rob Landley rob at landley.net
Thu Oct 15 17:03:33 PDT 2020


On 10/14/20 3:19 PM, enh via Toybox wrote:
> tar asks dirtree_path() to reserve space for a trailing '/', but recent
> changes broke that for the case that was resolving to just a strdup().
> 
> Caught by `export ASAN=1` and `make test_tar`.

P.S. I just downloaded ndk-21d to see if it had been fixed but:

/home/landley/android/android-ndk-r21d/toolchains/llvm/prebuilt/linux-x86_64/bin/../lib/gcc/x86_64-linux-android/4.9.x/../../../../x86_64-linux-android/bin/ld:
error: cannot mix -static with dynamic object
/home/landley/android/android-ndk-r21d/toolchains/llvm/prebuilt/linux-x86_64/lib64/clang/9.0.8/lib/linux/libclang_rt.asan-x86_64-android.so
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Nope, you still can't ASAN=1 with LDFLAGS=--static. Oh well...

Rob



More information about the Toybox mailing list