[Toybox] [PATCH] dirtree_path: always honor size request.

enh enh at google.com
Thu Oct 15 16:56:30 PDT 2020


yeah, that's unlikely to ever be supported. but note that you can use
`export ASAN=1` on the *host*. that's where i did my testing because
it's way faster than cross compiling and syncing and running on a 10x
slower cpu!

On Thu, Oct 15, 2020 at 4:53 PM Rob Landley <rob at landley.net> wrote:
>
> On 10/14/20 3:19 PM, enh via Toybox wrote:
> > tar asks dirtree_path() to reserve space for a trailing '/', but recent
> > changes broke that for the case that was resolving to just a strdup().
> >
> > Caught by `export ASAN=1` and `make test_tar`.
>
> P.S. I just downloaded ndk-21d to see if it had been fixed but:
>
> /home/landley/android/android-ndk-r21d/toolchains/llvm/prebuilt/linux-x86_64/bin/../lib/gcc/x86_64-linux-android/4.9.x/../../../../x86_64-linux-android/bin/ld:
> error: cannot mix -static with dynamic object
> /home/landley/android/android-ndk-r21d/toolchains/llvm/prebuilt/linux-x86_64/lib64/clang/9.0.8/lib/linux/libclang_rt.asan-x86_64-android.so
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Nope, you still can't ASAN=1 with LDFLAGS=--static. Oh well...
>
> Rob



More information about the Toybox mailing list