[Toybox] [PATCH] telnetd: pass `-h hostname` to login(1).

enh enh at google.com
Thu Apr 22 19:00:07 PDT 2021


Handling utmp is login's job: telnetd should just pass the appropriate
option to login.

(I was investigating a different bug that caused telnetd to take 100%
CPU after a network outage and noticed an unexpected utmp fd. It turned
out to not be relevant to my actual problem, but it did remind me that
this utmp code isn't right in small details like that, but also in the
bigger picture: it's writing the wrong information, and only on logout,
not login. But rather than try to fix it, let's just let login do its
job.)
---
 toys/pending/telnetd.c | 32 ++++++++++----------------------
 1 file changed, 10 insertions(+), 22 deletions(-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20210422/c0cb1c07/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-telnetd-pass-h-hostname-to-login-1.patch
Type: text/x-patch
Size: 3157 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20210422/c0cb1c07/attachment-0002.bin>


More information about the Toybox mailing list