[Toybox] [PATCH] telnetd: pass `-h hostname` to login(1).

[Rob Landley]

On 4/22/21 9:00 PM, enh via Toybox wrote:
> Handling utmp is login's job: telnetd should just pass the appropriate
> option to login.

Introducing a call to getnameinfo... you're doing a DNS lookup on yourself?
(Given that telnet isn't encrypted, I'd expect most of the calls to take place
in a LAN environment possibly with no gateway?)

Is this going to produce a different result from gethostname()?

> (I was investigating a different bug that caused telnetd to take 100%
> CPU after a network outage and noticed an unexpected utmp fd. It turned
> out to not be relevant to my actual problem, but it did remind me that
> this utmp code isn't right in small details like that, but also in the
> bigger picture: it's writing the wrong information, and only on logout,
> not login. But rather than try to fix it, let's just let login do its
> job.)

I'm all for ripping out the utmp plumbing here, I'm just confused about where
this data is coming from what what it's used for...

Rob