[Toybox] fyi, git.c code review comments

Rob Landley rob at landley.net
Wed Jan 18 03:26:22 PST 2023


On 1/17/23 20:00, enh via Toybox wrote:
> fyi, there were some fly-by code review comments against git.c when i did the
> last toybox update:
> 
> https://android-review.googlesource.com/c/platform/external/toybox/+/2385040?tab=comments 
> 
> (i'm assuming moritz reads the list?)

In theory, yes.

I've done some very simple code style cleanup, but detoured into reading the gif
file format docs before trying to work out object lifetime rules, and it's now
like 6 things down on my stack because interrupts... :)

(Pending. It's there for a reason. Seems like a good start though...)

Rob


More information about the Toybox mailing list