[Toybox] [PATCH] strace.c: add risc-v support, fix non-legacy architectures.

Rob Landley rob at landley.net
Fri Jan 27 21:57:30 PST 2023


On 1/27/23 10:57, enh wrote:
> (though that also means we can #include <linux/elf.h> instead of the "full"
> elf.h...)

That would make slightly more sense and alleviate the "should it be #included in
this command or in toys.h" itch, but pulling in a whole header for a constant 1
seem seems a bit overkill. This was introduced in Linux 1.2.10 and hasn't
changed since. Posix doesn't know about it, refspecs.linuxfoundation.org's Elf
ABI says of the type field "The ABI does not define what the descriptors mean"...

I just swapped a constant _back_ for FNM_LEADING_DIR (with the portability.h
#ifdef and #define for glibc not exporting it without #define
stallman_wgah_nagl_ftaghn despite BSD and MacOS doing so), so I'm running about
even on the constant abuse ledger if I yank this one. :)

Rob


More information about the Toybox mailing list