[Toybox] [PATCH] toysh: preventing segfaults when handling escaped newlines

Rob Landley rob at landley.net
Mon Sep 4 21:49:42 PDT 2023


On 9/4/23 19:10, Oliver Webb via Toybox wrote:
> This is my first time submitting a patch to a mailing list, So please
> forgive me if there's any etiquette or formatting I've missed.
> 
> This is a fix I found for a bug I submitted a issue to the github repo
> (issue #453) for a few days ago

Just saw this after posting
https://github.com/landley/toybox/issues/453#issuecomment-1705917574

It does indeed fix the issue, but not the underlying problem. There are several
other callers of parse_word() that make the same assumption, which is no longer
true after the referenced commit changed the design, so I need to change the
API. I'll try to get through that later tonight.

Thanks,

Rob


More information about the Toybox mailing list