[Toybox] [PATCH] toysh: preventing segfaults when handling escaped newlines

[Rob Landley]

On 9/4/23 23:49, Rob Landley wrote:
> On 9/4/23 19:10, Oliver Webb via Toybox wrote:
>> This is my first time submitting a patch to a mailing list, So please
>> forgive me if there's any etiquette or formatting I've missed.
>> 
>> This is a fix I found for a bug I submitted a issue to the github repo
>> (issue #453) for a few days ago
> 
> Just saw this after posting
> https://github.com/landley/toybox/issues/453#issuecomment-1705917574
> 
> It does indeed fix the issue, but not the underlying problem. There are several
> other callers of parse_word() that make the same assumption, which is no longer
> true after the referenced commit changed the design, so I need to change the
> API. I'll try to get through that later tonight.

I applied your fix as-is, then did a design fix on top of it (commit
0c13db503054). There are still problems with the backslash code, ala bash -c
$'XYZ=xyz; echo "abc$\\\nXYZ"' outputs "abcxyz" but toysh is outputting
"abc$XYZ" which again: larger design fix in the works.

I'm still working on toysh. At the moment there are 69 test failures in
"VERBOSE=allnopass make test_sh", which doesn't even include the outstanding
github issues or my TODO stack or some entire subsystems still not in yet...

Working on it,

Rob