[Aboriginal] aboriginal linux

[James McMechan]

just a couple comments

I would think that 

#define faccessat(A, B, C, D) faccessat(A, B, C, 0)

might better be as 

#define faccessat(A, B, C, D) faccessat(A, B, C, D & ( ~AT_SYMLINK_NOFOLLOW) )

so that when something actually wants to use AT_EACCESS it will either get passed through or fail noisily.
Long ago I developed a strong dislike for the library emulating features when GNU's glibc emulated aio by helpfully making my program multi-threaded and hijacking signals.

I found your workaround of multiple -e clauses simpler and easier to read, than the alternation "\|" but back in 1986 when I was learning about grep maybe it was more primitive, but even now I like the simple answer better.

Jim McMechan

----------------------------------------
> Date: Fri, 26 Sep 2014 20:26:05 -0500
> From: rob at landley.net
> To: stephen.n.turner at gmail.com
> CC: Aboriginal at lists.landley.net
> Subject: Re: [Aboriginal] aboriginal linux
>
> On 09/26/14 19:40, stephen Turner wrote:
>>> The fix I coded up that evening boiled down to adding a stanza to
>>> portability.h something like:
>>>
>>> #ifdef __MUSL__
>>> // Long explanation of why musl is wrong.
>>> #include <someheader.h>
>>> #define faccessat(A, B, C, D) faccessat(A, B, C, 0)
>>> #endif
>>>
>>> And then doing an echo "#define __MUSL__" to the end of features.h
>>> during the musl build in aboriginal. But I didn't check it in, and
>>
>> I was using the static compiled binary from your site when I had this
>> issue. Are you sure its musl lib? Is that what your building toybox
>> against currently?
>
> Yup, the 0.4.9 binaries were compiled against musl. (I did test them
> against musl, but obviously not thoroughly enough.)
>
> Next release should have it fixed.
>
>>>> Is the regex file the patch for grep -e?
>>>
>>> Yes. Internally grep is doing "REGEX1\|REGEX2\|REGEX3" to glue 'em
>>> together, and tre only supported | in extended regex mode, not as an
>>> escape in normal regex. So I fixed that.
>>>
>>> (I'll think about writing entirely posix compliant toybox code when
>>> somebody can tell me how to implement ps or losetup that way. Until
>>> then, linux has man pages that say we can do things, and I believe
>>> them.)
>>>
>>> Rob
>>
>> Should I be applying this patch to gcc, musl, or toybox?
>
> The regex patch is against musl.
>
> Rob
>
> _______________________________________________
> Aboriginal mailing list
> Aboriginal at lists.landley.net
> http://lists.landley.net/listinfo.cgi/aboriginal-landley.net
 		 	   		  
 1411868622.0