[Toybox] Fix, killall is not allowed to kill itself
Elie De Brauwer
eliedebrauwer at gmail.com
Sun Dec 16 09:12:59 PST 2012
All,
In my previous patch, the pif shouldn't be stored inside the GLOBAL(),
it should be just a regular global variable. In attach a patch which
corrects this.
gr
E.
On 12/16/2012 04:54 PM, Elie De Brauwer wrote:
> Hi all,
>
> The LSB specification of killall says "A killall process never kills
> itself (but may kill other killall processes)."
>
> The current implementation of killall does not adhere to this rule, with
> the patch in attach killall will adhere to this rule.
>
> Before:
> edb at lapedb:~/edb-stuff/toybox/toybox$ ./toybox killall -9 toybox
> Killed
>
> After:
> edb at lapedb:~/edb-stuff/toybox/toybox$ ./toybox killall -9 toybox
> killall: No such process
>
>
> Note: this patch should be applied after my previous submission, if for
> some reason the previous path is unwanted let me know and I'll resubmit
> this one.
>
> my 2 cents
> E.
>
--
Elie De Brauwer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: killall_may_not_kill_itself_take2.patch
Type: text/x-patch
Size: 901 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20121216/29541f5c/attachment-0007.bin>
More information about the Toybox
mailing list